-
Notifications
You must be signed in to change notification settings - Fork 732
Update WinRM Listener Code #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the examples used to create a HTTP or HTTPS WinRM listener to be compatible with both Windows PowerShell 5.1 and PowerShell 7.x. The `New-WSManInstance` only worked for WinPS and not for PS 7.x.
Should we backport these changes to 2.19 and earlier or just 2.20? |
I think if it cleanly backports to 2.19 it’s probably best to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jborean93
Backport to stable-2.19: 💚 backport PR created✅ Backport PR branch: Backported as #3106 🤖 @patchback |
Updates the examples used to create a HTTP or HTTPS WinRM listener to be compatible with both Windows PowerShell 5.1 and PowerShell 7.x. The `New-WSManInstance` only worked for WinPS and not for PS 7.x. (cherry picked from commit 3ecd3e5)
Backport to stable-2.20: 💚 backport PR created✅ Backport PR branch: Backported as #3107 🤖 @patchback |
Updates the examples used to create a HTTP or HTTPS WinRM listener to be compatible with both Windows PowerShell 5.1 and PowerShell 7.x. The `New-WSManInstance` only worked for WinPS and not for PS 7.x. (cherry picked from commit 3ecd3e5)
Updates the examples used to create a HTTP or HTTPS WinRM listener to be compatible with both Windows PowerShell 5.1 and PowerShell 7.x. The `New-WSManInstance` only worked for WinPS and not for PS 7.x. (cherry picked from commit 3ecd3e5) Co-authored-by: Jordan Borean <[email protected]>
Updates the examples used to create a HTTP or HTTPS WinRM listener to be compatible with both Windows PowerShell 5.1 and PowerShell 7.x. The `New-WSManInstance` only worked for WinPS and not for PS 7.x. (cherry picked from commit 3ecd3e5) Co-authored-by: Jordan Borean <[email protected]>
Updates the examples used to create a HTTP or HTTPS WinRM listener to be compatible with both Windows PowerShell 5.1 and PowerShell 7.x. The
New-WSManInstance
only worked for WinPS and not for PS 7.x.Fixes: #2709 (comment)